Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Add assertion that at least one base model was specified and throw an error message otherwise. #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add assertion that at least one base model was specified and throw an error message otherwise. #72

wants to merge 1 commit into from

Conversation

IanCarrasco
Copy link

@IanCarrasco IanCarrasco commented Sep 26, 2023 •
edited
Loading

Closes #46

mschrimpf
mschrimpf reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@mschrimpf mschrimpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution! Some submissions specify brain models directly, and in those cases the list of base models may indeed be empty. So ideally we would check that there is at least one base model or brain model.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mschrimpf mschrimpf mschrimpf left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty model list will not print anything
2 participants
@IanCarrasco @mschrimpf