email fix for score_plugins workflow #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvfairchild
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Some changes requested but (as long as this is fully tested), looks good to me.
As we're adding logic for notifying the submitter on failure across multiple actions, you may want to look into reusable workflows to centralize the logic and reduce duplication.
Co-authored-by: Katherine Fairchild <kvg0@mit.edu>
Good point @kvfairchild ! I'll merge this for now so we have emails going out to users and prioritize creating a reusable user-notifier action that can be used for this and other CI results. |
samwinebrake
added a commit
that referenced
this pull request
Mar 8, 2024
* email fix for score_plugins workflow (#581) * Emails passed to jenkins * Update .github/workflows/score_new_plugins.yml Co-authored-by: Katherine Fairchild <kvg0@mit.edu> * fix deprecated set output --------- Co-authored-by: Katherine Fairchild <kvg0@mit.edu> * add eBarlow_Vanilla to models (#587) Co-authored-by: AutoJenkins <brainscore@info.org> * add eBarlow_lmda_01 to models (#588) Co-authored-by: AutoJenkins <brainscore@info.org> * add cornet_s_0_0_0 to models (#589) Co-authored-by: AutoJenkins <brainscore@info.org> * add unet_ethan to models (#590) Co-authored-by: AutoJenkins <brainscore@info.org> * add unet_ethan to models (#591) Co-authored-by: AutoJenkins <brainscore@info.org> * Revert "add unet_ethan to models (#591)" (#594) This reverts commit c89059e. * Revert "add unet_ethan to models (#590)" (#595) This reverts commit 9a8774a. * Transfer plugin information by artifact for scoring runs (#592) * upload and download json artifact between jobs * fix testing changes * brain-score.org (user:514) | Add new plugin(s): models: [cornet_s_0_0_0 cornet_s_0_1_0] | (public:False) (#603) * add cornet_s_0_0_0 to models * add cornet_s_0_1_0 to models --------- Co-authored-by: AutoJenkins <brainscore@info.org> * Add microsaccades: interface and default model helper (#492) * integrate brain-score/model-tools#75 to brain-score/vision * add exception for when temp file write fails * fix error with tf temp file management * add bandaid to a DataAssembly index problem * move microsaccades to the model side * update comments * remove indexing bug * fix bug with activations.shape * Apply suggestions from code review Co-authored-by: Martin Schrimpf <mschrimpf@users.noreply.github.com> * Delete brainscore_vision/data/scialom2024/__init__.py * address review changes * remove needless import * fix bug with temporary file handling test * assume number_of_trials=1 and require_variance=False when getting stored activations * fix bug with access to ActivationsExtractorHelper.set_visual_degrees * move extractor calls to ModelCommitment generic * add check for whether activations_model exists * fix bug with TestVisualDegrees * add link to BrainModel issue * remove shifts from stimulus set packaging * change link signatures * change microsaccade call signature * microsaccades are now computed on both a pixel and degree basis * Apply suggestions from code review Co-authored-by: Martin Schrimpf <mschrimpf@users.noreply.github.com> * fix outdated comments, type hints, etc. * change function call to reduce repetition * add kwargs to microsaccade helpers * refactor microsaccade usage to their own class to improve readability * refactor microsaccade coords into MicrosaccadeHelper * refactor microsaccade building * change the way MultiIndex is set * fix tf/pytorch/keras bug with image shape calculation * cv2 reshaping in translate * add test for exact microsaccades * fix microsaccade indexing * rename test to be in line with current naming * add require_variance to _from_paths_stored * reduce unnecessarily long test times by reducing the number of trials tests run for, while keeping the test the same --------- Co-authored-by: Martin Schrimpf <mschrimpf@users.noreply.github.com> * Use MajajHong2015public.IT instead of mock data (#585) * Changed _MockBenchmark to new format * revert ceiler back to martin's suggestion * implemented MockBenchmark to use MJ2015 Public --------- Co-authored-by: Katherine Fairchild <kvg0@mit.edu> Co-authored-by: AutoJenkins <brainscore@info.org> Co-authored-by: Ben Lonnqvist <ben.lonnqvist@epfl.ch> Co-authored-by: Martin Schrimpf <mschrimpf@users.noreply.github.com> Co-authored-by: Michael Ferguson <mferg@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to closed PR #579
Broke that PR up into two parts:
Everything is tested and working, as long as secrets.AWS_ACCESS_KEY_ID and secrets.AWS_SECRET_ACCESS_KEY are set within vision.
(See previous comments from here for input on choices made in this PR.)