Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darkmode for Note in documentation #119

Closed
Commandserver opened this issue Oct 9, 2021 · 5 comments
Closed

Darkmode for Note in documentation #119

Commandserver opened this issue Oct 9, 2021 · 5 comments
Assignees
@braindigitalis
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@Commandserver
Copy link
Member

Commandserver commented Oct 9, 2021 •
edited
Loading

Describe the bug
Noteblock in darkmode in the documentation has white text color and light yellow as background so its unreadable.
Found this here https://dpp.dev/commandhandler.html

To Reproduce
Steps to reproduce the behavior:
Turn on darkmode

Expected behavior
The text to be in dark (black or so...)

Screenshots
grafik

System Details:

  • OS: Linux Ubuntu
  • Firefox latest version on desktop

Additional context
@Commandserver Commandserver added the bug Something isn't working label Oct 9, 2021
braindigitalis added a commit that referenced this issue Oct 10, 2021
@braindigitalis
fix dark colouration of FAQ, #119
a809b68
braindigitalis added a commit that referenced this issue Oct 10, 2021
@braindigitalis
amendment to #119 - -note-colour-darker is better for eyes
fd04374
@braindigitalis
Copy link
Contributor

Hi, thanks so much for the report!

I've adjusted the colour of the notes to --note-color-darker which looks like this in light mode and dark mode:

image

Please let me know if there are any other issues :)

@braindigitalis braindigitalis added the documentation Improvements or additions to documentation label Oct 10, 2021
@braindigitalis braindigitalis self-assigned this Oct 10, 2021
@j200283
Copy link

j200283 commented Oct 11, 2021

I have the same problem in win10's darkmod with Microsoft Edge and Chrome

OS: Windows 10 pro (20h2 - x64)
Chrome latest version on desktop / Microsoft Edge

@j200283
Copy link

j200283 commented Oct 11, 2021

Sorry, I forgot to put the image
image

braindigitalis added a commit that referenced this issue Oct 11, 2021
@braindigitalis
further fixes for #119
d0b423a
@braindigitalis
Copy link
Contributor

should be fine now, let me know how it looks for you 😄

@j200283
Copy link

j200283 commented Oct 11, 2021

thanks a lot : )
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@braindigitalis braindigitalis

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@braindigitalis @Commandserver @j200283