fix: avoid memory leaks in event_map #1043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes memory leaks detected by Valgrind which occur because events allocated in initialization of
eventmap
are never deallocated.These leaks are harmless because these objects are currently supposed to live for the whole duration of the program, but it's still good to not have these leaks at all. I fix them by making the pointers stored in
eventmap
(renamed toevent_map
for better readability) point to events with static storage duration. This way we also avoid unnecessary memory allocations.I should note that it seems a bit weird to me that these event objects live that long in the first place. They have no reason for that other than making the implementation simpler. It might be worth looking for a cleaner a solution in a separate PR.
Code change checklist