Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added newly_created bool to threads #1069

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

Jaskowicz1
Copy link
Contributor

This PR adds a newly_created bool to threads. As on_thread_create is also fired when a thread is added to an existing private thread (for example, adding a thread to a forum channel), there was no way to distinguish the actual creation event, Discord provides a newly_created bool so we now allow users to see that.

I avoided using the flags here in-case Discord add more flags (as dpp::channel_flags is close to its limit) to channels/threads.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit f7163b6
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65b40b2218f8b00008a7f12f
😎 Deploy Preview https://deploy-preview-1069--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1 Jaskowicz1 self-assigned this Jan 26, 2024
@braindigitalis
Copy link
Contributor

threads aren't cached, so bool is fine here

@Jaskowicz1
Copy link
Contributor Author

threads aren't cached, so bool is fine here

Ah good good!

@Jaskowicz1 Jaskowicz1 added enhancement New feature or request code Improvements or additions to code. labels Jan 26, 2024
@Jaskowicz1 Jaskowicz1 merged commit 12df0ab into brainboxdotcc:dev Jan 29, 2024
42 of 43 checks passed
@Jaskowicz1 Jaskowicz1 deleted the thread-improvements branch June 13, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants