Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added is_guild_owner for dpp::guild_member #1109

Merged
merged 6 commits into from
Mar 30, 2024
Merged

feat: Added is_guild_owner for dpp::guild_member #1109

merged 6 commits into from
Mar 30, 2024

Conversation

AA1999
Copy link
Contributor

@AA1999 AA1999 commented Mar 22, 2024 •
edited by Jaskowicz1
Loading

To check if said member is the guild owner.

Added a helper method so that checking if the member is the guild owner is easier.

Code change checklist

  • [✅] I have ensured that all methods and functions are fully documented using doxygen style comments.
  • [✅] My code follows the coding style guide.
  • [✅] I tested that my change works before raising the PR.
  • [✅] I have ensured that I did not break any existing API calls.
  • [✅] I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify Netlify
Copy link

netlify bot commented Mar 22, 2024 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 3e0f960
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6607cf1c93a3bd00089424ef
😎 Deploy Preview https://deploy-preview-1109--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Mar 22, 2024
braindigitalis
braindigitalis requested changes Mar 23, 2024
View reviewed changes
src/dpp/guild.cpp Outdated Show resolved Hide resolved
braindigitalis
braindigitalis reviewed Mar 24, 2024
View reviewed changes
include/dpp/guild.h Outdated Show resolved Hide resolved
@Jaskowicz1 Jaskowicz1 changed the title Added a method is_guild_owner for dpp::guild_member to check if said … feat: Added a method is_guild_owner for dpp::guild_member to check if said … Mar 28, 2024
@Jaskowicz1 Jaskowicz1 changed the title feat: Added a method is_guild_owner for dpp::guild_member to check if said … feat: Added is_guild_owner for dpp::guild_member to check if said … Mar 28, 2024
@Jaskowicz1
Copy link
Contributor

Renamed this PR to correctly align with our conventions.

@Jaskowicz1 Jaskowicz1 changed the title feat: Added is_guild_owner for dpp::guild_member to check if said … feat: Added is_guild_owner for dpp::guild_member Mar 30, 2024
@Jaskowicz1 Jaskowicz1 merged commit 908588c into brainboxdotcc:dev Mar 30, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mishura4 Mishura4 Mishura4 left review comments

@Jaskowicz1 Jaskowicz1 Jaskowicz1 approved these changes

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees
No one assigned
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AA1999 @Jaskowicz1 @Mishura4 @braindigitalis