Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty presences will now warn #1121

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix: empty presences will now warn #1121

merged 1 commit into from
Apr 4, 2024

Conversation

Jaskowicz1
Copy link
Contributor

This PR no longer allows empty presences for set_presence. It will now give a warning.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Jaskowicz1 Jaskowicz1 self-assigned this Apr 3, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 3, 2024 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 0968ef9
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/660d44402b790d0008c1a7e3
😎 Deploy Preview https://deploy-preview-1121--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the code Improvements or additions to code. label Apr 3, 2024
@Jaskowicz1 Jaskowicz1 linked an issue Apr 3, 2024 that may be closed by this pull request
set_presence() giving error 4002: decode error #1113
Closed
@Jaskowicz1 Jaskowicz1 merged commit 3ac877c into brainboxdotcc:dev Apr 4, 2024
44 checks passed
@Jaskowicz1 Jaskowicz1 deleted the presence-changes branch June 13, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees

@Jaskowicz1 Jaskowicz1

Labels
code Improvements or additions to code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set_presence() giving error 4002: decode error
2 participants
@Jaskowicz1 @braindigitalis