Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capturing "bot" is not needed. Removing it resolves an unused variabl… #1132

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Erarnitox
Copy link
Contributor

Alternatively you could please mark the bot variable as unused by casting it to void.
This would clean up a warning for library consumers who happen to build unit tests also.

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit f635c9d
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/661ee8c6b0ba920008c9b186
😎 Deploy Preview https://deploy-preview-1132--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the code Improvements or additions to code. label Apr 16, 2024
@Mishura4
Copy link
Member

I force rebased the PR to the latest version of dev. Waiting on the actions to complete then I'll merge

@Mishura4 Mishura4 merged commit 6288cb8 into brainboxdotcc:dev Apr 16, 2024
42 of 43 checks passed
@Erarnitox Erarnitox deleted the small_nit branch April 16, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants