Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Silence GUILD_SOUNDBOARD_* websocket events, currently undocumented #1148

Merged
merged 2 commits into from
May 10, 2024
Merged

FIX: Silence GUILD_SOUNDBOARD_* websocket events, currently undocumented #1148

merged 2 commits into from
May 10, 2024

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented May 10, 2024 •
edited
Loading

[ Please outline your change here. Be sure to check the checkboxes below. ]

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis added enhancement New feature or request audio audio issues or feature requests code Improvements or additions to code. labels May 10, 2024
@braindigitalis braindigitalis self-assigned this May 10, 2024
@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 2053cc1
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/663e8edd1016e40009598774
😎 Deploy Preview https://deploy-preview-1148--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mishura4
Copy link
Member

8po6y2

@braindigitalis
Copy link
Contributor Author

lets do this! its release time!

shipit-revert

@braindigitalis braindigitalis merged commit fa5d7d5 into dev May 10, 2024
74 of 75 checks passed
@braindigitalis braindigitalis deleted the silence-soundboard-events branch May 10, 2024 21:33
@underflowerror underflowerror mentioned this pull request Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mishura4 Mishura4 Mishura4 approved these changes

@Jaskowicz1 Jaskowicz1 Awaiting requested review from Jaskowicz1

Assignees

@braindigitalis braindigitalis

Labels
audio audio issues or feature requests code Improvements or additions to code. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braindigitalis @Mishura4