Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing entitlement type enum values #1171

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Jun 13, 2024

These enums didnt exist when the draft API was documented. Now they do, so they're added.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Jun 13, 2024
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 0bb8c0e
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/666b63a7c84a4800089dc607
😎 Deploy Preview https://deploy-preview-1171--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis added enhancement New feature or request breaking This pull request introduces breaking changes code Improvements or additions to code. labels Jun 13, 2024
@braindigitalis
Copy link
Contributor Author

NOTE: Breaking, as it corrects the enum values to what the final API actually sends!

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 13, 2024
@braindigitalis braindigitalis merged commit f52afff into dev Jun 13, 2024
74 of 76 checks passed
@braindigitalis braindigitalis deleted the add-entitlement-enum-values branch June 13, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This pull request introduces breaking changes code Improvements or additions to code. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants