-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove coroutine/DPP_CORO experimental warnings #1221
Conversation
Remove "experimental" notice from DPP_CORO's comment.
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing
Line 48 in ced36fd
* @warning - This feature is EXPERIMENTAL. The API may change at any time and there may be bugs. |
Line 103 in ced36fd
* @warning - This feature is EXPERIMENTAL. The API may change at any time and there may be bugs. Please report any to <a href="https://github.com/brainboxdotcc/DPP/issues">GitHub issues</a> or to the <a href="https://discord.gg/dpp">D++ Discord server</a>. |
Line 292 in ced36fd
message("-- ${Yellow}Enabled experimental coroutine feature${ColourReset}") |
message()
).
Line 87 in ced36fd
* @warning - This feature is EXPERIMENTAL. The API may change at any time and there may be bugs. |
DPP/include/dpp/coro/coroutine.h
Line 67 in ced36fd
* @warning - This feature is EXPERIMENTAL. The API may change at any time and there may be bugs. |
Any update on this? |
should I just remove these comments altogether? |
Removed notices of coroutines being an experimental feature.
Documentation change checklist
doxygen
, and testing examples).