-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change encryption to AEAD XChaCha20 Poly1305 #1239
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Currently only have encrypting wrote (not sure if it works). |
https://discord.com/channels/825407338755653642/887255721392099378/1285665235612733592 lol Discord changed encryption again, what a joke. |
we need to get this working then progress on to dave, lets split it into 2 parts |
Will do it over the weekend :)
…On Wed, 18 Sep 2024 at 22:08, Craig Edwards (Brain) < ***@***.***> wrote:
we need to get this working then progress on to dave, lets split it into 2
parts
—
Reply to this email directly, view it on GitHub
<#1239 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALF2B6M2TGN2PUIAQKHCDKTZXHTWBAVCNFSM6AAAAABNPFUXZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJZGQYDOOJQGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@Neko-Life has got this working with encryption and decryption using XChaCha20, this is tested so we should perhaps merge this, then put out a release to make the new encryption available in the interim before we can do the DAVE nonesense in a separate pr. |
Aye good idea
…On Sat, 21 Sep 2024 at 17:59, Craig Edwards (Brain) < ***@***.***> wrote:
@Neko-Life <https://github.com/Neko-Life> has got this working with
encryption and decryption using XChaCha20, this is tested so we should
perhaps merge this, then put out a release to make the new encryption
available in the interim before we can do the DAVE nonesense in a separate
pr.
—
Reply to this email directly, view it on GitHub
<#1239 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALF2B6OPG4NGNQF7V776E53ZXWQW3AVCNFSM6AAAAABNPFUXZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGI2TGMBWHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YUGE. Rather clean code too!
This PR introduces
AEAD XChaCha20 Poly1305 (RTP Size)
as the encryption method for voice data.AEAD AES256-GCM (RTP Size)
will not be introduced in this PR as it is simply a suggestion (Discord declares it as a "preference", however, it's easier to just stick withXChaCha20 Poly1305
) therefore, after discussions internally, we will stick with justAEAD XChaCha20 Poly1305 (RTP Size)
Code change checklist