Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change encryption to AEAD XChaCha20 Poly1305 #1239

Merged
merged 12 commits into from
Sep 21, 2024

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Sep 1, 2024

This PR introduces AEAD XChaCha20 Poly1305 (RTP Size) as the encryption method for voice data.

AEAD AES256-GCM (RTP Size) will not be introduced in this PR as it is simply a suggestion (Discord declares it as a "preference", however, it's easier to just stick with XChaCha20 Poly1305) therefore, after discussions internally, we will stick with just AEAD XChaCha20 Poly1305 (RTP Size)

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 454fce4
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/66eefa873ca46a00088bf018
😎 Deploy Preview https://deploy-preview-1239--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the code Improvements or additions to code. label Sep 1, 2024
@Jaskowicz1
Copy link
Contributor Author

Currently only have encrypting wrote (not sure if it works).

@Jaskowicz1
Copy link
Contributor Author

https://discord.com/channels/825407338755653642/887255721392099378/1285665235612733592

lol Discord changed encryption again, what a joke.

@braindigitalis
Copy link
Contributor

we need to get this working then progress on to dave, lets split it into 2 parts

@Jaskowicz1
Copy link
Contributor Author

Jaskowicz1 commented Sep 18, 2024 via email

@braindigitalis
Copy link
Contributor

@Neko-Life has got this working with encryption and decryption using XChaCha20, this is tested so we should perhaps merge this, then put out a release to make the new encryption available in the interim before we can do the DAVE nonesense in a separate pr.

@Jaskowicz1
Copy link
Contributor Author

Jaskowicz1 commented Sep 21, 2024 via email

@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review September 21, 2024 17:02
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YUGE. Rather clean code too!

@braindigitalis braindigitalis merged commit ce18453 into dev Sep 21, 2024
92 checks passed
@braindigitalis braindigitalis deleted the encryption_updates branch October 11, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants