Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup namespaces and unneeded includes #1295

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 20, 2024

Removes redundant includes from the cpp files.
Also as we agreed we didnt need to flag namespace closing with a comment (all good ides can do this and we rarely go more than one namespace deep, the dpp namespace) i have gone through and removed them.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Oct 20, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 20, 2024
Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit e1a309e
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6714d959cbc3410008749eb9
😎 Deploy Preview https://deploy-preview-1295--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Neko-Life Neko-Life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Need rebase, probably <cstdint> in dev can be removed too

@braindigitalis braindigitalis merged commit 8f26e78 into dev Oct 20, 2024
89 of 90 checks passed
@braindigitalis braindigitalis deleted the include-tidyup branch October 20, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants