Change slashcommand json serialization #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braindigitalis
approved these changes
May 17, 2021
braindigitalis
pushed a commit
that referenced
this pull request
Jan 30, 2022
braindigitalis
pushed a commit
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #18 , there is an issue with the json serialization when we have sub-commands with options
Based on https://github.com/nlohmann/json#arbitrary-types-conversions I created three
to_jsonfunctions, one to serialize slashcommand, one to command_option and one to command_option_choice, the main functionbuild_jsonis now much simpler and just creates the json object and adds the id field if necessary, the conversion is done automatically via each function.