Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: delete message count on cluster::guild_ban_add is now scaled in seconds instead of days #489

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

Commandserver
Copy link
Member

@Commandserver
Copy link
Member Author

Commandserver commented Aug 29, 2022

hm should we add something in the method to log a warning message when a value of 1 to 7 is passed to delete_message_seconds? So that the users know they should take a look at it

@braindigitalis
Copy link
Contributor

hm should we add something in the method to log a warning message when a value of 1 to 7 is passed to delete_message_seconds? So that the users know they should take a look at it

yes sounds.sensible

@Commandserver
Copy link
Member Author

We can also multiply the value, if its 1 - 7, by 86400 seconds. So basically it will calculate the value to seconds. I mean who tf will ban a player and delete the messages of lets say the last 5 seconds. Think we can asume then, that they've not updated their code.

@Commandserver
Copy link
Member Author

Or both, logging and multiplying

@braindigitalis
Copy link
Contributor

definitely just the warning - changing the value is confusing and what if you actually want a 5 second delete range?

@Commandserver
Copy link
Member Author

can you do the logging stuff for me @braindigitalis ?

@Commandserver
Copy link
Member Author

i dont really know how to do that

@braindigitalis
Copy link
Contributor

this->log(ll_warn, "Oopsy woopsy you did a fucky wucky!");

this, inside any cluster method. not that literal text though lol

@braindigitalis braindigitalis merged commit 965e322 into brainboxdotcc:dev Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants