Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unverified bots default intent. #500

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Conversation

AA1999
Copy link
Contributor

@AA1999 AA1999 commented Sep 6, 2022

Same as i_default_intents but also has i_message_content intent.

include/dpp/intents.h Outdated Show resolved Hide resolved
@Commandserver
Copy link
Member

Does unverified bots have message content intent enabled by default? 🤔

@braindigitalis
Copy link
Contributor

no, this only applies to unverified bots added before the change not new ones created today

the message content is still a privileged intent and should not be made default by dpp

@AA1999
Copy link
Contributor Author

AA1999 commented Sep 9, 2022

Any unverified bot that is below 100 server should have no problems using message intents tho, right?
Discord made it clear it's only a thing for verified bots anyways (or the bots at 100 servers)

@braindigitalis
Copy link
Contributor

Any unverified bot that is below 100 server should have no problems using message intents tho, right? Discord made it clear it's only a thing for verified bots anyways (or the bots at 100 servers)

yes but it is still a privileged intent and you still have to go into developer page and turn it on... we would be introducing issues later when the bot grows and they then require approval to use the intent...

@AA1999
Copy link
Contributor Author

AA1999 commented Sep 10, 2022

It is called unverified bots intent for a reason

@braindigitalis
Copy link
Contributor

still shouldn't be defaulted imho, it becomes something else later and people will get used to having it enabled

@braindigitalis
Copy link
Contributor

hmm this actually looks different to what I saw before.... I'll merge it later

@raxyte
Copy link
Contributor

raxyte commented Sep 10, 2022

still shouldn't be defaulted imho, it becomes something else later and people will get used to having it enabled

Agreed with this statement here.

@raxyte
Copy link
Contributor

raxyte commented Sep 10, 2022

It's really unnecessary and in-fact over-thought imo.

@AA1999
Copy link
Contributor Author

AA1999 commented Sep 10, 2022

It's not replacing the default_intents
It's just a handy alternative for people making bots that are private/never gonna reach 100 servers

@raxyte
Copy link
Contributor

raxyte commented Sep 10, 2022

It's not replacing the default_intents It's just a handy alternative for people making bots that are private/never gonna reach 100 servers

I'm aware it's not replacing that, but I still feel the same. Rest is up to @braindigitalis.

@Commandserver
Copy link
Member

Commandserver commented Sep 10, 2022

It's really unnecessary and in-fact over-thought imo.

I agree tbh. If people need the message content intent, they should just pass that besides the default intents. It also makes it not really easier to use

@AA1999
Copy link
Contributor Author

AA1999 commented Sep 11, 2022

We already have a all intents that people might wrongly get used to.
We could maybe rename it better but I feel like it's not really a bad addition

@Commandserver
Copy link
Member

We already have a all intents that people might wrongly get used to.
We could maybe rename it better but I feel like it's not really a bad addition

I would suggest i_defaults_and_message_intents

@es183923
Copy link
Contributor

That is literally just as verbose as i_default_intents | i_message_content

@AA1999
Copy link
Contributor Author

AA1999 commented Sep 11, 2022

Idk just feels like having aliases is fine

We already have a all intents that people might wrongly get used to.
We could maybe rename it better but I feel like it's not really a bad addition

I would suggest i_defaults_and_message_intents

Seems fine to me, we'll let brain decide

@AA1999
Copy link
Contributor Author

AA1999 commented Sep 11, 2022

Maybe i_private_bots_default_intents?

@braindigitalis braindigitalis merged commit 13c63a9 into brainboxdotcc:dev Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants