Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssl client has
The problem is, is that the time could change between the condition on line 1, and setting it on line 3. This can't be changed, as it would cause bugs in other places. The poll syscall further down can be reworked to wake up at the beginning of the second to make it less likely for the time difference on lines 1, and 3 to occur. Other parts of the code rely on specific times to operate, and they may be skipped over regardless, this just makes it far less likely to occur.
I'm aware, that sslclient is running on its own thread, and there may be many running, it might be best to stagger the wake up at a random interval
(beginning of second + rand(0 to 100) milliseconds)
.