added explicit casting to avoid warnings #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| } | ||
|
|
||
| int discord_voice_client::udp_recv(char* data, size_t max_length) | ||
| { | ||
| return recv(this->fd, data, (int)max_length, 0); | ||
| return (int) recv(this->fd, data, (int)max_length, 0); |
There was a problem hiding this comment.
why do you need this?
The correct return type for recv is int already according to the standards? same with sendto
There was a problem hiding this comment.
In MacOS the return type is not int it is ssize_t which is indeed a long. Therefore it is a mapping from long to int which is causing the warning. Its not critical from my point of view but the build would be cleaner.
ssize_t recv(int, void *, size_t, int) __DARWIN_ALIAS_C(recv);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a MacOS 13.2 with Xcode 14.2 I received the following warnings.
Implicit conversion loses integer precision: 'unsigned long' to 'uint32_t' (aka 'unsigned int')
Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
Added casts solved the warnings and is still consistent with the intention of the code.