-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cluster::interaction_followup_get_original #723
feat: cluster::interaction_followup_get_original #723
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
doesnt this do what |
Yes, from dpp::interaction_create_t ; however this is similar to the Having a method on the cluster notably allows for sync and coro convenience calls ; for example with PR #724 one can do |
There is no such thing as "original followup" in the API. |
So then should we remove Or leave it but only add |
Im for removing the old interaction_followup_edit_original |
It's more confusing than helpful having this duplication anyway |
Sure. I think it might have been meant to be |
we can't just remove it, things are using it. it would have to be deprecated, but there is a reason it's called "original": https://discord.com/developers/docs/interactions/receiving-and-responding#followup-messages the API endpoint contains the string "@original". it was originally called the "original response" and was renamed to "initial response". both mean the same thing. definitely do not delete! |
also it's in the API docs section about follow up messages. the API docs on interactions are a mess. |
That is not a followup message. Followup endpoints are at the bottom of the page. Also, there is nothing using that function inside DPP. |
This PR adds a method for the Get Original Interaction Response API endpoint, which is quite essential in order to use raw interactions. It also adds
interaction_response_get_original
as an alias for it, similar tointeraction_response_create
. Also adds sync and coro methods for both.