Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added avatar decoration url to the dpp::user class #732

Merged
merged 4 commits into from
Sep 16, 2023
Merged

feat: added avatar decoration url to the dpp::user class #732

merged 4 commits into from
Sep 16, 2023

Conversation

Commandserver
Copy link
Member

@Commandserver Commandserver commented Jul 17, 2023 •
edited by braindigitalis
Loading

discord/discord-api-docs@3074b5f

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Jul 17, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 3e8bdd9
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64b56b3841ede40008bdcbcd
😎 Deploy Preview https://deploy-preview-732--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Commandserver
Copy link
Member Author

Commandserver commented Jul 19, 2023 •
edited
Loading

not sure if we want this feature at all. It's currently in beta. I wonder why this feature is even documented, but hey it's discord...
Also:

The available selection of avatar decorations will change periodically, and can be used by Nitro Subscribers for a limited time only.

https://support.discord.com/hc/en-us/articles/13410113109911-Avatar-Decorations
I think no one is seriously using this in their bots. At least not yet

@braindigitalis
Copy link
Contributor

not sure if we want this feature at all. It's currently in beta. I wonder why this feature is even documented, but hey it's discord... Also:

The available selection of avatar decorations will change periodically, and can be used by Nitro Subscribers for a limited time only.

support.discord.com/hc/en-us/articles/13410113109911-Avatar-Decorations I think no one is seriously using this in their bots. At least not yet

If its documented, its staying around, lets include it. Is this ready to merge yet?

@Commandserver
Copy link
Member Author

If its documented, its staying around, lets include it. Is this ready to merge yet?

It's ready but untested

@Commandserver Commandserver added the on hold This pull request or issue is not being worked on at present label Aug 6, 2023
braindigitalis
braindigitalis requested changes Aug 13, 2023
View reviewed changes
Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change to approved once we know how it works

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@braindigitalis
Copy link
Contributor

it's been two months, is this happening or did discord shitcan the fearure?

@Jaskowicz1
Copy link
Contributor

https://discord.com/developers/docs/resources/user#user-object It exists, and mishura used to use it too. Might be worth testing?

@braindigitalis braindigitalis added enhancement New feature or request on hold This pull request or issue is not being worked on at present and removed on hold This pull request or issue is not being worked on at present labels Sep 16, 2023
@braindigitalis braindigitalis marked this pull request as ready for review September 16, 2023 18:24
@braindigitalis braindigitalis removed the on hold This pull request or issue is not being worked on at present label Sep 16, 2023
@braindigitalis braindigitalis merged commit a7dbdff into brainboxdotcc:dev Sep 16, 2023
Mishura4 pushed a commit to Mishura4/DPP-PRs that referenced this pull request Sep 17, 2023
@Commandserver @Mishura4
feat: added avatar decoration url to the dpp::user class (brainboxdot…
e2989ea 
…cc#732)
@Jaskowicz1 Jaskowicz1 mentioned this pull request Sep 25, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Commandserver @braindigitalis @CLAassistant @Jaskowicz1