break: remove co_attach & enforce event handler call semantics (return void/dpp::job, take const event) #807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context (accessible to reviewers)
For non-reviewers, the tl;dr is
std::function
does very little to enforce call semantics such as a return type.This PR actually enforces the call semantics using type traits. It also removes co_attach and now unifies usage for coro / non coro event handlers (you attach a coro event handler using
attach
oroperator()
).dev
branch.