Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bad compile defs #844

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Remove bad compile defs #844

merged 1 commit into from
Sep 4, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Sep 4, 2023

this fixes warnings when building vcpkg with msvc. I'll submit a more in depth tidy up when I have facility to test it properly without having to wait until a vcpkg pr.

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@braindigitalis braindigitalis changed the base branch from master to dev September 4, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants