Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: added object editing example #847

Merged
merged 21 commits into from
Sep 8, 2023
Merged

Conversation

Henonicks
Copy link
Contributor

@Henonicks Henonicks commented Sep 7, 2023

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit defcf43
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64fa1affc80ee600087d83f7
😎 Deploy Preview https://deploy-preview-847--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docpages/example_programs/the_basics/editing-objects.md Outdated Show resolved Hide resolved
docpages/example_programs/the_basics.md Outdated Show resolved Hide resolved
docpages/example_programs/the_basics/editing-objects.md Outdated Show resolved Hide resolved
docpages/example_programs/the_basics/editing-objects.md Outdated Show resolved Hide resolved
docpages/example_programs/the_basics/editing-objects.md Outdated Show resolved Hide resolved
docpages/images/stuff_edit1.png Outdated Show resolved Hide resolved
docpages/example_programs/the_basics/editing-objects.md Outdated Show resolved Hide resolved
docpages/example_programs/the_basics/editing-objects.md Outdated Show resolved Hide resolved
@Henonicks
Copy link
Contributor Author

Henonicks commented Sep 7, 2023

Please, don't send me the hate speech about losing the bot token I already hate myself 😭

@Jaskowicz1
Copy link
Contributor

Please, don't send me the hate speech about losing the bot token I already hate myself 😭

Reset your bot token. That push can now always be viewed.

@Henonicks
Copy link
Contributor Author

Reset your bot token. That push can now always be viewed.

Safety Gym did it for me

… code, renamed editing-objects.md into editing-channel-and-message.md (hopefully didn't miss anything)
@Henonicks Henonicks requested a review from Jaskowicz1 September 7, 2023 14:58
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple last things :)

@Henonicks Henonicks requested a review from Jaskowicz1 September 7, 2023 18:22
@Henonicks
Copy link
Contributor Author

Also added a note about bot's inability to edit messages sent by others

@Jaskowicz1
Copy link
Contributor

Yeah pretty happy with this now :)

@braindigitalis braindigitalis merged commit 927db26 into brainboxdotcc:dev Sep 8, 2023
Mishura4 pushed a commit to Mishura4/DPP-PRs that referenced this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants