Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): fix include_directories for installed target #863

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

leha-bot
Copy link
Contributor

It fixes the include directories propagation from dpp::dpp to any consuming target (via target_link_libraries(mybot dpp::dpp)). See CMake's target_include_directories() for reference.

  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 06c49ca
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65096799591519000802af34
😎 Deploy Preview https://deploy-preview-863--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2023

CLA assistant check
All committers have signed the CLA.

@braindigitalis braindigitalis merged commit c79da97 into brainboxdotcc:dev Sep 19, 2023
@leha-bot leha-bot deleted the fix/cmake-include-dirs branch September 22, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants