Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve AVX, make detection a little nicer #865

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

braindigitalis
Copy link
Contributor

  • split out isa into four separate files, rather than one long snakepit of #ifdef
  • pass flags properly to caller, and have the caller set the compile flags and define
  • set the define as a fixed name with a value 0, 1, 2 or 512, instead of four different defines
  • Test compiled successfully on my server (AVX2) and my raspberry pi 4b (AVX0 fallback) More tests especially on windows welcome
  • My pull request is made against the dev branch.
  • I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • I tested my commits, by adding a test case to the unit tests if needed
  • I have ensured that I did not break any existing API calls.
  • My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

split out isa into four separate files, rather than one long snakepit of #ifdef
pass flags properly to caller, and have the caller set the compile flags and define
set the define as a fixed name with a value 0, 1, 2 or 512, instead of four different defines
@braindigitalis braindigitalis self-assigned this Sep 19, 2023
@braindigitalis braindigitalis added enhancement New feature or request audio audio issues or feature requests labels Sep 19, 2023
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit cb2c445
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/650a16421e7a350008a66870
😎 Deploy Preview https://deploy-preview-865--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RealTimeChris RealTimeChris merged commit 2e75d3d into dev Sep 19, 2023
@Jaskowicz1 Jaskowicz1 deleted the rewrite_avx_specifics branch April 4, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio audio issues or feature requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants