Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: prevent ci runs being cancelled by github incorrectly (backwards) #910

Merged
merged 3 commits into from
Oct 2, 2023
Merged

ci: prevent ci runs being cancelled by github incorrectly (backwards) #910

merged 3 commits into from
Oct 2, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 2, 2023 •
edited
Loading

https://github.com/orgs/community/discussions/53506
https://www.polpiella.dev/cancelling-unnecessary-github-actions-automatically/

Values for cancel concurrent swapped over, so that PRs dont all stack up crazy-like.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 2, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit d7c122e
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/651af1e3125aa50008cc1a3f
😎 Deploy Preview https://deploy-preview-910--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis changed the title ci: prevent ci runs being cancelled by github, cancel-in-progress doesnt do what its supposed to do; this is a known github issue ci: prevent ci runs being cancelled by github, cancel-in-progress is backwards, documentation being followed had issues Oct 2, 2023
@braindigitalis braindigitalis changed the title ci: prevent ci runs being cancelled by github, cancel-in-progress is backwards, documentation being followed had issues ci: prevent ci runs being cancelled by github incorrectly (backwards) Oct 2, 2023
@braindigitalis braindigitalis self-assigned this Oct 2, 2023
@braindigitalis braindigitalis marked this pull request as ready for review October 2, 2023 16:39
@braindigitalis braindigitalis merged commit 01d31d4 into dev Oct 2, 2023
10 of 49 checks passed
@braindigitalis braindigitalis deleted the remove_concurrency_ci branch October 2, 2023 16:45
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mishura4 Mishura4 Mishura4 approved these changes

Assignees

@braindigitalis braindigitalis

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braindigitalis @Mishura4