Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: change two namespace on one line to dpp::event #925

Merged
merged 7 commits into from
Oct 6, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 5, 2023

changed namespace dpp { namespace event { to C++17 style namespace dpp::event {

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Oct 5, 2023
@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 9fa7cb2
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/651f475de4bb640008e6d6c3
😎 Deploy Preview https://deploy-preview-925--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 5, 2023
@braindigitalis braindigitalis requested a review from raxyte October 5, 2023 23:04
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of lines

@braindigitalis braindigitalis merged commit 545e7ff into dev Oct 6, 2023
49 checks passed
@braindigitalis braindigitalis deleted the deep_namespaces branch October 6, 2023 01:51
@braindigitalis braindigitalis added the hacktoberfest-accepted Issues tagged for hacktoberfest label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation hacktoberfest-accepted Issues tagged for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants