Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug introduced by #927 #928

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Conversation

Mishura4
Copy link
Member

@Mishura4 Mishura4 commented Oct 7, 2023

UNIT TEST SUMMARY
==================
Instantiate DPP cluster                                      PASS
cluster::start method                                        PASS
Connection to client websocket                               PASS
Creation of application command                              PASS
Deletion of application command                              PASS
Log events                                                   PASS
Creation of a channel message                                PASS
Editing a channel message                                    PASS
Message edit event                                           PASS
Deletion of a channel message                                PASS
Receipt of a created message                                 PASS
Message attachment send and check                            PASS
Test guild cache                                             PASS
Test user cache                                              PASS
React to a message                                           PASS
Reaction event                                               PASS
Receive guild create event                                   PASS
Get messages                                                 PASS
crossplatform_strptime()                                     PASS
utility::iconhash                                            PASS
cluster::current_user_get()                                  PASS
cluster::guild_get()                                         PASS
cluster::channel_get()                                       PASS
cluster::channels_get()                                      PASS
cluster::roles_get()                                         PASS
cluster::guild_get_invites()                                 PASS
cluster::guild_get_bans()                                    PASS
cluster::channel_pins_get()                                  PASS
cluster::guild_events_get()                                  PASS
cluster::guild_event_get()                                   PASS
message_create_t::send()                                     PASS
cluster::guild_event_users_get()                             PASS
start timer                                                  PASS
stop timer                                                   PASS
one-shot timer                                               PASS
timed listener                                               PASS
Presence intent                                              PASS
Instantiate a cache                                          PASS
message_collector                                            PASS
managed::get_creation_date()                                 PASS
utility::read_file()                                         PASS
ts_to_string()                                               PASS
ts_not_null()                                                PASS
command_option_choice::fill_from_json: double                PASS
command_option_choice::fill_from_json: int64_t               PASS
command_option_choice::fill_from_json: bool                  PASS
command_option_choice::fill_from_json: snowflake             PASS
command_option_choice::fill_from_json: string                PASS
https_client::get_host_info()                                PASS
https_client HTTPS request                                   PASS
https_client HTTP request                                    PASS
run_once<T>                                                  PASS
webhook construct from URL                                   PASS
Markdown escaping (ignore code block contents)               PASS
Markdown escaping (escape code block contents)               PASS
URL encoding                                                 PASS
Base 64 encoding                                             PASS
sync<T>()                                                    PASS
manged object comparison                                     PASS
find_channel()                                               PASS
channel type flags                                           PASS
create a forum channel                                       PASS
retrieve the created forum channel                           PASS
delete the created forum channel                             PASS
Human readable error translation                             PASS
cluster::guild_ban_add ban three deleted discord accounts    PASS
cluster::guild_get_ban getting one of the banned accounts    PASS
cluster::guild_get_bans get bans using the after-parameter   PASS
cluster::guild_ban_delete unban the banned discord accounts  PASS
cluster::thread_create                                       PASS
cluster::on_thread_create event                              PASS
cluster::channel_delete with thread                          PASS
cluster::on_thread_delete event                              PASS
cluster::thread_edit                                         PASS
cluster::on_thread_update event                              PASS
cluster::threads_get_active                                  PASS
creating a voice channel                                     PASS
editing the created voice channel                            PASS
deleting the created voice channel                           PASS
permission                                                   PASS
event class                                                  PASS
cluster::user_get                                            PASS
cluster::user_get flag parsing                               PASS
cluster::guild_get_member                                    PASS
user::get_mention                                            PASS
user::get_url                                                PASS
user::format_username                                        PASS
user::get_creation_time                                      PASS
user::get_avatar_url                                         PASS
channel::set_type                                            PASS
channel::get_mention                                         PASS
channel::get_url                                             PASS
message::get_url                                             PASS
utility::guild_navigation                                    PASS
utility::iconhash                                            PASS
utility::make_url_parameters                                 PASS
utility::markdown_escape                                     PASS
utility::tokenize                                            PASS
utility::url_encode                                          PASS
utility::slashcommand_mention                                PASS
utility::channel_mention                                     PASS
utility::user_mention                                        PASS
utility::role_mention                                        PASS
utility::emoji_mention                                       PASS
utility::user_url                                            PASS
utility::message_url                                         PASS
utility::channel_url                                         PASS
utility::thread_url                                          PASS
utility::avatar_size                                         PASS
utility::cdn_endpoint_url_hash                               PASS
sticker::get_url aka utility::cdn_endpoint_url_sticker       PASS
emoji::get_url                                               PASS
role::operator<                                              PASS
cluster::role_create                                         PASS
cluster::role_edit                                           PASS
cluster::role_delete                                         PASS
JSON parse error for post_rest                               PASS
cluster::user_get_cached_sync() with present member          PASS
cluster::user_get_cached_sync() with not present member      PASS
interaction_create_t::get_parameter() with subcommands       PASS
interaction_create_t::get_parameter() without subcommands    PASS
cluster::automod_rule_create                                 PASS
cluster::automod_rule_get                                    PASS
cluster::automod_rules_get                                   PASS
cluster::automod_rule_delete                                 PASS
using the cluster::request method to fetch an image          PASS
cluster::guild_emoji_create                                  PASS
cluster::guild_emoji_get                                     PASS
cluster::guild_emoji_delete                                  PASS
cluster::on_invite_create                                    PASS
cluster::on_invite_delete                                    PASS
cluster::channel_invite_create                               PASS
cluster::invite_get                                          PASS
cluster::invite_delete                                       PASS
multiheader cookie test                                      PASS
Connect to voice channel                                     PASS
Send audio to voice channel                                  FAIL
Pinning a channel message                                    PASS
Unpinning a channel message                                  PASS
cluster::thread_member_add                                   PASS
cluster::thread_member_get                                   PASS
cluster::thread_members_get                                  PASS
cluster::thread_member_remove                                PASS
cluster::on_thread_members_update event with member addition PASS
cluster::on_thread_members_update event with member removal  PASS
cluster::thread_create_with_message                          PASS
message manipulation in thread                               PASS
cluster::on_message_create in thread                         PASS
cluster::on_message_edit in thread                           PASS
cluster::on_message_delete in thread                         PASS
cluster::on_reaction_add in thread                           PASS
cluster::on_reaction_remove in thread                        PASS
coro: offline job                                            SKIPPED
coro: offline coroutine                                      SKIPPED
coro: offline task                                           SKIPPED
coro: offline async                                          SKIPPED
coro: online event handler                                   SKIPPED
coro: online api calls                                       SKIPPED
coro: online mumbo jumbo in event handler                    SKIPPED

Surely this time

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 7, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit d52c824
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6520d39411e3ed00082ce97f
😎 Deploy Preview https://deploy-preview-928--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the code Improvements or additions to code. label Oct 7, 2023
@Mishura4 Mishura4 marked this pull request as draft October 7, 2023 03:43
@Mishura4
Copy link
Member Author

Mishura4 commented Oct 7, 2023

I do not know why Send audio to voice channel fails, this appears to be always the case these days for me on Windows

@Mishura4 Mishura4 marked this pull request as ready for review October 7, 2023 03:51
@Mishura4
Copy link
Member Author

Mishura4 commented Oct 7, 2023

@Mishura4 Mishura4 merged commit aac3f0b into brainboxdotcc:dev Oct 7, 2023
28 checks passed
@Mishura4 Mishura4 deleted the json3 branch October 9, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants