Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Been on a refactor binge #941

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Been on a refactor binge #941

merged 4 commits into from
Oct 11, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Oct 11, 2023 •
edited
Loading

  • Fix: broken event data in on_message_delete, on_role_delete
  • Improvement: improved detail for many other delete events, where we can give partial information instead of none for a delete event or give ids
  • Refactor: Remove using namespace dpp and using json = nlohmann::json in event handler source files

Please do not squash-merge this PR

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis
Fix: broken event data in on_message_delete, on_role_delete
e383b04 
Improvement: improved detail for many other delete events, where we can give partial information instead of none for a delete event or give ids
Refactor: Remove `using namespace dpp` and `using json = nlohmann::json` in event handler source files
@braindigitalis braindigitalis self-assigned this Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit a338fe2
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65268153ebfea60008c7fbf4
😎 Deploy Preview https://deploy-preview-941--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 11, 2023
Jaskowicz1
Jaskowicz1 reviewed Oct 11, 2023
View reviewed changes
src/dpp/events/guild_member_remove.cpp Outdated Show resolved Hide resolved
src/dpp/events/guild_delete.cpp Outdated Show resolved Hide resolved
include/dpp/dispatcher.h Show resolved Hide resolved
src/dpp/events/channel_delete.cpp Outdated Show resolved Hide resolved
src/dpp/events/guild_role_delete.cpp Show resolved Hide resolved
Jaskowicz1
Jaskowicz1 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@braindigitalis braindigitalis merged commit 2cfaeb5 into dev Oct 11, 2023
60 checks passed
@braindigitalis braindigitalis deleted the delete_ids branch October 11, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaskowicz1 Jaskowicz1 Jaskowicz1 approved these changes

Assignees

@braindigitalis braindigitalis

Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braindigitalis @Jaskowicz1