Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dpp::application is now updated, added set_iconhash_not_null #953

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

Jaskowicz1
Copy link
Contributor

This PR now updates dpp::application, making it up-to-date (and even have content discord doesn't document yet). It also adds set_iconhash_not_null, meaning we don't have to do workarounds to set the iconhash as it can be set from a string.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Jaskowicz1 Jaskowicz1 self-assigned this Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 74abd25
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6530e5cf2a8c9d00080e738c
😎 Deploy Preview https://deploy-preview-953--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1 Jaskowicz1 linked an issue Oct 18, 2023 that may be closed by this pull request
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 18, 2023
src/dpp/application.cpp Outdated Show resolved Hide resolved
@Jaskowicz1
Copy link
Contributor Author

Jaskowicz1 commented Oct 19, 2023

Some of the new data I have added seems to maybe be in relation to this update, adding premium subscriptions in the US. However, the data is still undocumented and that update doesn't say anything about that data at all.

@braindigitalis braindigitalis merged commit 623ed2f into brainboxdotcc:dev Oct 19, 2023
34 checks passed
@Jaskowicz1 Jaskowicz1 deleted the application_updates branch November 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dpp::application object is missing many fields
2 participants