Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(coro): deprecate dpp::job handler & push dpp::task instead, and remove static_assert in dpp::job #958

Merged
merged 2 commits into from
Oct 22, 2023
Merged

refactor(coro): deprecate dpp::job handler & push dpp::task instead, and remove static_assert in dpp::job #958

merged 2 commits into from
Oct 22, 2023

Conversation

Mishura4
Copy link
Member

@Mishura4 Mishura4 commented Oct 19, 2023 •
edited
Loading

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 19, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit a48a2c2
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6532fa8cdbcf3a0007dcf40e
😎 Deploy Preview https://deploy-preview-958--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 19, 2023
@Mishura4 Mishura4 removed the documentation Improvements or additions to documentation label Oct 19, 2023
@Mishura4 Mishura4 marked this pull request as ready for review October 19, 2023 20:38
@Mishura4 Mishura4 marked this pull request as draft October 19, 2023 21:05
@Mishura4 Mishura4 marked this pull request as ready for review October 21, 2023 20:45
@Mishura4
Copy link
Member Author

Feel free to review and squash merge this one
tests are broken on current dev at the time of this comment though, updating this branch will make them fail as well

@braindigitalis braindigitalis merged commit e72ac76 into brainboxdotcc:dev Oct 22, 2023
34 checks passed
@Mishura4 Mishura4 deleted the coro branch October 24, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees
No one assigned
Labels
code Improvements or additions to code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mishura4 @braindigitalis