Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: updated nlohmann to 3.11.2 #991

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Nov 2, 2023

This PR updates nlohmann json to 3.11.2.

This was originally done in #982, but we've heard nothing back and we aren't 100% sure this works (our CIs do say this works, but a real test case is required for this as it's a huge change).

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 60db8bb
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65436f46c18ce800088cc32f
😎 Deploy Preview https://deploy-preview-991--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the code Improvements or additions to code. label Nov 2, 2023
@Jaskowicz1 Jaskowicz1 mentioned this pull request Nov 2, 2023
5 tasks
@Jaskowicz1 Jaskowicz1 added dependencies Pull requests that update a dependency file build Issue or Pull Request related to the build process labels Nov 2, 2023
@Jaskowicz1 Jaskowicz1 self-assigned this Nov 2, 2023
@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review November 2, 2023 11:06
@Jaskowicz1
Copy link
Contributor Author

This PR is now marked as ready for review. It has been tested with my bot and works!

@braindigitalis braindigitalis merged commit c2a30f8 into brainboxdotcc:dev Nov 2, 2023
35 checks passed
@Jaskowicz1 Jaskowicz1 deleted the updating-json branch November 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or Pull Request related to the build process code Improvements or additions to code. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants