Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integer autocompletes no longer cause crash #992

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Jaskowicz1
Copy link
Contributor

This PR fixes #962, checking if a value from an autocomplete is actually what we expect it to be, rather than unsafely assuming. This caused a crash because discord sends "" upon on_autocomplete (no data), however, because the type is int, it can't convert to int so it throws instead. This no longer happens and we now just don't bother with the set if the type doesn't match.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit ea31ce5
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65439472759572000826dd1e
😎 Deploy Preview https://deploy-preview-992--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1 Jaskowicz1 added the bug Something isn't working label Nov 2, 2023
@Jaskowicz1 Jaskowicz1 merged commit cb17478 into brainboxdotcc:dev Nov 2, 2023
35 checks passed
@Jaskowicz1 Jaskowicz1 deleted the fix-autocomplete branch November 2, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code Improvements or additions to code.
Projects
None yet
2 participants