Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed the way messages holds files #999

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Nov 6, 2023

This PR changes the way that messages hold files. Rather than there being 3 vectors of strings for: name, content and mimetypes, there is now a vector of message_file_data structs.

This doesn't break the way you add files, but rather breaks the way you read files you've added to a message.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Jaskowicz1 Jaskowicz1 added the breaking This pull request introduces breaking changes label Nov 6, 2023
@Jaskowicz1 Jaskowicz1 self-assigned this Nov 6, 2023
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 527f2e9
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6549f7d891bbc30007eb5c18
😎 Deploy Preview https://deploy-preview-999--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Nov 6, 2023
@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review November 6, 2023 21:47
@Jaskowicz1
Copy link
Contributor Author

image
image
This is proof of it still working!

src/dpp/cluster/appcommand.cpp Outdated Show resolved Hide resolved
@Jaskowicz1 Jaskowicz1 marked this pull request as draft November 7, 2023 08:13
@Jaskowicz1
Copy link
Contributor Author

Reverted to draft as more changes are required.

@Jaskowicz1 Jaskowicz1 marked this pull request as ready for review November 7, 2023 08:41
@Jaskowicz1
Copy link
Contributor Author

No longer in draft, ready for review!

@braindigitalis braindigitalis merged commit 4f16307 into brainboxdotcc:dev Nov 8, 2023
34 checks passed
@Jaskowicz1 Jaskowicz1 deleted the message-file-redo branch November 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This pull request introduces breaking changes code Improvements or additions to code. documentation Improvements or additions to documentation project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants