-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: changed the way messages holds files #999
Merged
braindigitalis
merged 6 commits into
brainboxdotcc:dev
from
Jaskowicz1:message-file-redo
Nov 8, 2023
Merged
refactor: changed the way messages holds files #999
braindigitalis
merged 6 commits into
brainboxdotcc:dev
from
Jaskowicz1:message-file-redo
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
documentation
Improvements or additions to documentation
code
Improvements or additions to code.
labels
Nov 6, 2023
braindigitalis
requested changes
Nov 6, 2023
Reverted to draft as more changes are required. |
No longer in draft, ready for review! |
braindigitalis
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
This pull request introduces breaking changes
code
Improvements or additions to code.
documentation
Improvements or additions to documentation
project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way that messages hold files. Rather than there being 3 vectors of strings for: name, content and mimetypes, there is now a vector of
message_file_data
structs.This doesn't break the way you add files, but rather breaks the way you read files you've added to a message.
Code change checklist