Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable coil set value 0 and 1 instead of 0x0000 and 0xFF00 #14

Closed
brainelectronics opened this issue Jul 16, 2022 · 0 comments
Closed

Enable coil set value 0 and 1 instead of 0x0000 and 0xFF00 #14

brainelectronics opened this issue Jul 16, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@brainelectronics
Copy link
Owner

As found in #10 COIL does not accept 1, True or False as value. It only accepts 0, see

micropython-modbus/umodbus/functions.py

Lines 46 to 47 in dd5b8e5

def write_single_coil(output_address, output_value):
if output_value not in [0x0000, 0xFF00]:

@brainelectronics brainelectronics added the bug Something isn't working label Jul 16, 2022
brainelectronics added a commit that referenced this issue Jul 16, 2022
@brainelectronics
extend list of allowed output values of write_single_coil values to 0…
87a764e 
…, 1, False, True, 0x0, 0xFF00, resolve #14
@brainelectronics brainelectronics mentioned this issue Jul 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brainelectronics