-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Info about rust release #386
Conversation
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
The example needs an update according to #385:
|
publishing to crates.io is blocked by rust-lang/crates.io#40 possible solutions are:
Building C\C++ code from Rust is not an option. |
Why not? In my first version I did exactly that. |
|
#386 (comment) first of all because technically it's exactly the same as downloading binary files since source code should be downloaded from github first but in addition it requires compilation Also, this way rust users will need to install CMake, Visual Studio, and some very specific components for Visual Studio(correct winsdk version, atl package, smth from UWP to work with BLE, etc). Finally, it's extra work to reproduce CMake options in Rust build script. |
But you are downloading ~30MB now of which 2 / 3 you don't need because they are for different platforms. If you do that for all your dependencies it will blow up. Adding CMake options to the build script isn't really that much and it's a one time thing. |
It's just 20MB for all platforms and also it can be separated by OS if at a certain point these files will be too big. 20MB is literally nothing and it's way easier to download it than wait for compilation. Numpy whl is 14MB, TensorFlow whl for CPU is almost 500MB for example and everybody is using it as a precompiled binary, even in Tensorflow for Rust they download binaries by default(https://github.com/tensorflow/rust#usage), 10MB limitation in a package registry is very weird as for me |
for TF you only download the binary for your platform. What you want is to ship binaries for Windows, Linux, and Mac. Two third of that payload you don't need. I don't know how it is for crates.io but it's likely they pay for their traffic so it's reasonably for them to keep it small. Also, if you have many dependencies it adds up. Image 10 dependencies with 60MB each... Building from source has pros and cons but I think the pros outweigh |
No description provided.