Update Galea default command and log Galea gain values #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrey1994
approved these changes
Feb 22, 2024
Andrey1994
reviewed
Feb 22, 2024
There was a problem hiding this comment.
obviously that will work, but maybe it would make more sense to get them from the board instead internal map which can be wrong in case of hw issues.
But I dont know the intention behind this. In case if you want programmatic access to get info about particular channel I would change that to smth like get_gains_for_channel_%num%. Otherwise you will need to parse the string
|
We were having issues with the GUI and FW gain settings not matching up with the Brainflow gain settings. We wanted a way to print all Brainflow gains for debugging purposes. I understand it is not the cleanest solution but it worked for our use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.