Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some slow tests fail locally #282

Closed
alessandrofelder opened this issue Nov 28, 2023 · 3 comments
Closed

[BUG] Some slow tests fail locally #282

alessandrofelder opened this issue Nov 28, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@alessandrofelder
Copy link
Member

alessandrofelder commented Nov 28, 2023

Describe the bug
Slow, local tests (not run on CI) fail locally.

To Reproduce
Clone this repo, then

conda create -n test python=3.11
pip install -e .[dev]
pytest --runslow --runlocal

on local Ubuntu desktop gives:

FAILED tests/test_gui.py::test_simple_launch - TypeError: 'PySide2.QtCore.Qt.WindowType' object cannot be interpreted as an integer
FAILED tests/test_integration.py::test_animation - OSError: [Errno 39] Directory not empty: '/home/alessandro/dev/brainrender/tests/examples'
FAILED tests/test_streamlines.py::test_download - TypeError: object of type 'NoneType' has no len()
FAILED tests/test_streamlines.py::test_download_slow - TypeError: object of type 'NoneType' has no len()
FAILED tests/test_streamlines.py::test_streamlines - TypeError: 'NoneType' object is not subscriptable

Expected behaviour
Tests pass

Log file
NA

Screenshots
NA

Computer used (please complete the following information):
Ubuntu 22.04

Additional context
NA

@alessandrofelder alessandrofelder added the bug Something isn't working label Nov 28, 2023
@alessandrofelder
Copy link
Member Author

  • test_gui::test_simple_launch now fixed, presumably thanks to switching to pyqt5 backend
  • Hypothesised cause of test_integration::test_animation merging of test and example data (see examples/video.py)

@adamltyson
Copy link
Member

The remaining tests seem to be failing due to #266

@alessandrofelder
Copy link
Member Author

The remaining tests seem to be failing due to #266

Agreed, closing.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Core development Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants