Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ISFC to use the new I/O and image modules #209

Merged
merged 2 commits into from
Apr 25, 2017
Merged

Refactor ISFC to use the new I/O and image modules #209

merged 2 commits into from
Apr 25, 2017

Conversation

mihaic
Copy link
Member

@mihaic mihaic commented Apr 21, 2017

No description provided.

@mihaic mihaic requested a review from cbaldassano April 21, 2017 02:03
@mihaic
Copy link
Member Author

mihaic commented Apr 21, 2017

@cbaldassano, I think the changes to ISFC are minor. Could you please review?

cbaldassano
cbaldassano approved these changes Apr 25, 2017
View reviewed changes
Copy link
Collaborator

@cbaldassano cbaldassano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for refactoring this interface

@mihaic
Copy link
Member Author

mihaic commented Apr 25, 2017

@cbaldassano, thanks for the review.

@mihaic mihaic merged commit 917cfa8 into brainiak:master Apr 25, 2017
@mihaic mihaic deleted the refactor-isfc branch April 25, 2017 18:20
danielsuo pushed a commit that referenced this pull request Nov 16, 2017
@robertnishihara @pcmoritz
print python backtrace in error message (#209)
49decce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbaldassano cbaldassano cbaldassano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaic @cbaldassano