Update req to 0.4.4 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@medoror, Maybe editing your PR message to also add One thing that I noticed, we don't have CI for this project yet, would it be desirable to add a simple one to ensure there's no regression on PRs, @brainlid ? |
|
@Cardosaum I went ahead and added the basic CI test runs. Note, it does not, and will not, run live tests against external services. Thanks for the suggestion to finally push me to do it. :) |
brainlid
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests on main seem to be broken at the moment. I did validate that running
mix test --include live_callbefore and after the req upgrade resulted in the no change to test output