Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable structured outputs for Google AI #255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sglyon
Copy link

@sglyon sglyon commented Feb 12, 2025

This quick change is something I needed locally to get structured JSON outputs from the gemini models: https://ai.google.dev/gemini-api/docs/structured-output?lang=rest

@brainlid
Copy link
Owner

brainlid commented Feb 14, 2025

Thanks for working to add structured output for Google Gemini!

I'm wondering, does adding structured output really remove the ability to set topP and topK?

I'd love to see some test coverage for the addition as well, to help ensure it doesn't have an unintended regression at some point.

And, assuming that the topP and topK are still valid, then the settings could be added to the config map in another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants