Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong randomness in ou process input #713

Open
Newtonpula opened this issue Jan 23, 2025 · 1 comment · May be fixed by #715
Open

wrong randomness in ou process input #713

Newtonpula opened this issue Jan 23, 2025 · 1 comment · May be fixed by #715
Labels
bug Something isn't working

Comments

@Newtonpula
Copy link

In brainpy._src.inputs.current, the ou_process

def _f(t):
    x.value = x + dt * ((mean - x) / tau) + sigma * dt_sqrt * rng.rand(n)
    return x.value

rng.rand(n) should be rng.randn(n)

@Newtonpula Newtonpula added the bug Something isn't working label Jan 23, 2025
@Routhleck
Copy link
Member

Thank you for your report! I’ll submit a pull request to address this issue right away.

@Routhleck Routhleck linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants