Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Show comments for a unlisted posts #93

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

Nikschavan
Copy link
Collaborator

@Nikschavan Nikschavan commented Feb 23, 2022

Description

Since the begnning of the plugin, comments of the unlisted posts are not displayed. which is not accurate as comments should be displayed regardless the post is listed or unlisted

Fixes #89

Screenshots

Types of changes

Breaking change

How has this been tested?

PHPUnit test case

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

Nikschavan and others added 2 commits February 23, 2022 15:42
Since the begnning of the plugin, comments of the unlisted posts are not displayed. which is not accurate as comments should be displayed regardless the post is listed or unlisted
@codeclimate
Copy link

codeclimate bot commented Feb 23, 2022

Code Climate has analyzed commit 29fc28a and detected 0 issues on this pull request.

View more on Code Climate.

@Nikschavan Nikschavan merged commit 5594168 into master Feb 23, 2022
@Nikschavan Nikschavan deleted the hidden-comments branch February 23, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments disappear when a post is unlisted
3 participants