Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode13-beta3 Fix #345

Merged
merged 8 commits into from
Jul 26, 2021
Merged

Xcode13-beta3 Fix #345

merged 8 commits into from
Jul 26, 2021

Conversation

scannillo
Copy link
Contributor

@scannillo scannillo commented Jul 20, 2021

Background

  • Sister PR in braintree_ios
  • Result of GH Issue Plugin uses APIs made unavailable to extensions in iOS 15/Xcode 13b3 #343
  • XCode 13-beta3 release notes call out the following change:

    Linking Swift packages from application extension targets or watchOS applications no longer emits unresolvable warnings about linking to libraries not safe for use in application extensions. This means that code referencing APIs annotated as unavailable for use in app extensions must now themselves be annotated as unavailable for use in application extensions, in order to allow that code to be used in both apps and app extensions. (66928265)

Changes

  • In places that we use Apple APIs which aren't usable in App Extensions (UIApplication.sharedApplication) we need to explicitly mark these methods as not usable for App Extensions.
  • Use dot syntax when available.
  • Bump InAppSettingsKit (used for Demo app) to v3.3.2 which includes XCode13-beta3 fixes.

Checklist

  • Added a changelog entry

Authors

@scannillo

@scannillo scannillo marked this pull request as ready for review July 22, 2021 19:09
@scannillo scannillo requested a review from a team as a code owner July 22, 2021 19:09
@@ -5,18 +5,18 @@
"package": "braintree_ios",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This Package.resolved is for the Demo app.

Copy link
Contributor

@sarahkoop sarahkoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Curious is there a newer version of the Xcode 13 image for CI?

@scannillo
Copy link
Contributor Author

Looks good to me. Curious is there a newer version of the Xcode 13 image for CI?

So, they have updated their images to include the latest Xcode13-beta3 (build #13A5192j). But the syntax for the actual yml file didn't need to change, it is still labeled as /Applications/Xcode_13.0.app.

I was able to catch these issues in CI, so it is working to use the latest beta.

CHANGELOG.md Show resolved Hide resolved
@scannillo scannillo merged commit 4678150 into master Jul 26, 2021
@scannillo scannillo deleted the fix-xcode-13-beta3 branch July 26, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants