Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-in Secondary description should allow >1 lines. #45

Closed
nirinchev opened this issue Sep 7, 2015 · 4 comments
Closed

Drop-in Secondary description should allow >1 lines. #45

nirinchev opened this issue Sep 7, 2015 · 4 comments

Comments

@nirinchev
Copy link

We have a case where we want to put a multiline secondary description. Is there any reason to limit it to 1 line? On iOS it works as expected, so I would assume it's a copy-paste bug on Android.

@sdcoffey
Copy link

sdcoffey commented Sep 8, 2015

Hey @nirinchev, thanks for letting us know. Just to clarify, you're referring to the drop-in activity, at the top where we show the cart? Eg:

screen shot 2015-09-08 at 9 32 16 am

@nirinchev
Copy link
Author

Yes, exactly. The text that says "1 Item" is limited to one line, while multiple lines should be ok. Looking at the code, it would seem that https://github.com/braintree/braintree_android/blob/master/Drop-In/src/main/res/layout/bt_payment_description.xml#L37 is the culprit, but I am not familiar with the codebase enough to be sure.

@sdcoffey
Copy link

sdcoffey commented Sep 9, 2015

Yep, you'd be right. We'll take a closer look at this tomorrow.
On Tue, Sep 8, 2015 at 15:43 Nikola Irinchev notifications@github.com
wrote:

Yes, exactly. The text that says 1 Item is limited to one line, while
multiple lines should be ok. Looking at the code, it would seem that
https://github.com/braintree/braintree_android/blob/master/Drop-In/src/main/res/layout/bt_payment_description.xml#L37
is the culprit, but I am not familiar with the codebase enough to be sure.


Reply to this email directly or view it on GitHub
#45 (comment)
.

@lkorth
Copy link
Member

lkorth commented Oct 5, 2015

@nirinchev: this was fixed in 1.7.0.

@lkorth lkorth closed this as completed Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants