Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE with connectivityManager.getActiveNetworkInfo() in AnalyticsEvent #128

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Fix NPE with connectivityManager.getActiveNetworkInfo() in AnalyticsEvent #128

merged 1 commit into from
Nov 8, 2016

Conversation

evastos
Copy link
Contributor

@evastos evastos commented Nov 8, 2016

When called consecutively, connectivityManager.getActiveNetworkInfo() may return different values. Storing the NetworkInfo object in a variable fixes wild NPEs in AnalyticsEvent.getNetworkType.

StackOverflow link

@lkorth
Copy link
Member

lkorth commented Nov 8, 2016

Thanks for the PR @evastos!

@lkorth lkorth merged commit c4b198a into braintree:master Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evastos @lkorth