Add Explicit Master Key Alias for Encrypted Shared Prefs #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scannillo
reviewed
Oct 24, 2022
| @@ -27,7 +28,7 @@ private BraintreeSharedPreferences() {} | |||
|
|
|||
| static SharedPreferences getSharedPreferences(Context context) { | |||
| try { | |||
| MasterKey masterKey = new MasterKey.Builder(context) | |||
| MasterKey masterKey = new MasterKey.Builder(context, BRAINTREE_KEY_ALIAS) | |||
There was a problem hiding this comment.
So basically this change switches from using the default key alias, to using com.braintreepayments.api.masterkey.
I know we use BraintreeSharedPreferences for config caching, but is there anything else it is used for that is merchant-facing, where changing this key value could break a merchant integration? Could they be relying on it for anything?
There was a problem hiding this comment.
Not that I can think of. The storage is mostly ephemeral, even config is cached for 5 minutes at a time I believe.
jcnoriega
approved these changes
Oct 25, 2022
sshropshire
force-pushed
the
shared_prefs_key_alias
branch
from
680f549
to
548f0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors