-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Venmo One Touch button iOS SDK #103
Comments
Thanks @SolomonBier - we'll look into this. |
@SolomonBier I believe the log statement you are seeing is probably due to a missing
We need to add that I would appreciate it if you could confirm my explanation by setting a breakpoint in your own project and stepping through that particular switch and ensuring that you are actually getting into the Venmo case, then falling through to the default case. But if you're noticing this logging, it sounds like the app switch to Venmo is not actually working for you, which is why you reported this issue. Correct? If so, we should dig into this further. |
@burnto I saw that too. Adding the break statement yield returns a UIAlertView that says "PayPal Error". Again the PayPal button hooks to the PayPal app, then immediately returns, but doesn't update the payment method. I believe that hits this method:
Which then returns the below
|
@burnto any updates on this ? |
We've released a fix for the missing |
@mickeyreiss I just updated to 3.8 I believe and this still isn't working, and neither is Paypal. |
Is your integration currently using sandbox, or production? We'll look into this soon. Thanks for your patience. |
@intelliot sandbox, thought I'm still receiving the paypal error notification. It seems that the break was added, but is still returning the paypal error I posted earlier: I believe that hits this method:
Which then returns the below
|
I'm looking into this now. Are you using CocoaPods, and if so, which version? Could you provide an example project that exhibits this error? If you don't want to post it on GitHub, you may email it to me: elliot.lee@getbraintree.com |
Are you testing this in the Simulator, or on a real device? Which version of iOS? |
@intelliot real device, and yes I am using pods. I don't think its possible for my to email you my huge repository. I'll reach out to you via email. |
Does the problem occur in the Simulator? I've identified a potential issue with Venmo where the card selector sometimes doesn't appear, but it doesn't seem related to the error you're seeing. |
Just worked with @SolomonBier to debug this issue. We successfully solved the two problems: (1) PayPal: We were not checking the URL correctly, so the AppDelegate wasn't passing the url to Braintree. We should clarify our docs to make (1) easier. Also, there's a bug in our SDK that cause "PayPal Error" to display for non-PayPal errors. We'll make sure this error gets surfaced correctly in a future SDK update. Thank you! |
…tch-CFBundleDisplayName-error Fix Venmo app switch crash when CFBundleDisplayName is nil
Fixed in 7c1465c |
saved to be more generic - it was referencing PayPal before It now says "Connection Error" in English (en) and is localized for other languages
Clicking on the Venmo button returns the following error:
BTPaymentButton collection view received didSelectItemAtIndexPath for unknown indexPath. This should never happen.
OneTouch is enabled. **EDIT: PayPal looks like it does not work now. It hooks to the PayPal app and then returns to the original app without updating anything.
The text was updated successfully, but these errors were encountered: