Removed Venmo `fallbacktoWeb` #1434

stechiu · 2024-10-15T00:28:51Z

Removed Venmo fallbacktoWeb opt-in to default to universal link

Summary of changes

Removed fallbacktoWeb and replaced with universal link

Checklist

Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@stechiu

jaxdesmarais

We will want to change the base branch to v7. I think we can also clean up the logic in BTVenmoAppSwitchRedirectURL to only use universal links.

Sources/BraintreeVenmo/BTVenmoClient.swift

scannillo · 2024-10-16T16:32:12Z

Like Jax mentioned, since this change removes something from the SDKs public interface, it will break a merchant app who might be integrating with this property. So this PR should target v7 branch

stechiu · 2024-10-16T17:11:12Z

Like Jax mentioned, since this change removes something from the SDKs public interface, it will break a merchant app who might be integrating with this property. So this PR should target v7 branch

I totally forgot to change the target branch. Just fixed!

stechiu · 2024-10-16T20:25:24Z

TODO: Fix failing tests

jaxdesmarais

Looks like when we changed the base branch, that branch wasn't up to date with the latest from main. We will need to merge the latest from main into v7 then merge the latest from v7 into your branch to remove that portion of the diff from this PR.

stechiu · 2024-10-17T16:45:49Z

Looks like when we changed the base branch, that branch wasn't up to date with the latest from main. We will need to merge the latest from main into v7 then merge the latest from v7 into your branch to remove that portion of the diff from this PR.

Updated. How often do we merge changes from main branch to feature branches?

…v7-venmo-universal-link

…o v7-venmo-universal-link # Conflicts: # CHANGELOG.md

jaxdesmarais · 2024-10-17T18:12:14Z

Updated. How often do we merge changes from main branch to feature branches?

I normally try to update long lived feature branches once a week. If a large feature is merged in we may want to update it sooner, but that's generally what I've done previously.

… into v7-venmo-universal-link" This reverts commit 438dfc7, reversing changes made to 1a24560.

…e/braintree_ios into v7-venmo-universal-link

Sources/BraintreeVenmo/BTVenmoClient.swift

warmkesselj · 2024-10-21T17:19:48Z

Sources/BraintreeVenmo/BTVenmoClient.swift

@@ -100,7 +99,7 @@ import BraintreeCore
            }

            do {
-                _ = try self.verifyAppSwitch(with: configuration, fallbackToWeb: request.fallbackToWeb)
+                _ = try self.verifyAppSwitch(with: configuration)


Does verifyAppSwitch need to bother with returning any value?

I assumed it would still need to return true since verifyAppSwitch checks if Venmo is enabled and if Venmo app is installed. Let me know if you think it's ok to remove the Bool return otherwise

If verifyAppSwitch is only being used here I think it should be safe. I think the function will just throw an error if not enabled, and the returned value isn't being used.

Sources/BraintreeVenmo/BTVenmoClient.swift

jaxdesmarais

Can we update BTVenmoAppSwitchRedirectURL to only have references to the universal link method?

stechiu · 2024-10-23T00:20:15Z

Can we update BTVenmoAppSwitchRedirectURL to only have references to the universal link method?

Good call, I've removed urlSchemeURL()

jaxdesmarais

Are we able to verify things are working as expected with these changes? If you have the Venmo app installed it should switch to the app and back and if the app is removed we should fallback to the default browser.

CHANGELOG.md

Sources/BraintreePayPal/BTPayPalClient.swift

Sources/BraintreePayPal/BTPayPalReturnURL.swift

Sources/BraintreeVenmo/BTVenmoClient.swift

…v7-venmo-universal-link # Conflicts: # CHANGELOG.md # Demo/Application/Features/VenmoViewController.swift # Sources/BraintreeVenmo/BTVenmoClient.swift # Sources/BraintreeVenmo/BTVenmoRequest.swift # V7_MIGRATION.md

stechiu · 2024-10-25T02:28:20Z

Are we able to verify things are working as expected with these changes? If you have the Venmo app installed it should switch to the app and back and if the app is removed we should fallback to the default browser.

Yep :) It looks great

Screen.Recording.2024-10-24.at.5.47.35.PM.mov

Braintree.podspec

Braintree.xcodeproj/project.pbxproj

Sources/BraintreeCore/BTHTTP.swift

CHANGELOG.md

…v7-venmo-universal-link

… into v7-venmo-universal-link" This reverts commit 438dfc7, reversing changes made to 1a24560.

…intree_ios into v7-venmo-universal-link"" This reverts commit 2d0d7e0.

…v7-venmo-universal-link

stechiu · 2024-10-28T20:51:42Z

retest this please

warmkesselj

Approving ahead of time. Just this final comment on my end: #1434 (comment)

agedd

lgtm!

jaxdesmarais · 2024-10-30T14:43:36Z

Sources/BraintreeVenmo/BTVenmoClient.swift

            } catch {
                self.notifyFailure(with: error, completion: completion)
-                return


I think we will want to add back this return, my guess is that this is why these tests are failing:

BTVenmoClient_Tests.testTokenize_whenVenmoRequest_setsVaultAnalyticsTag() BTVenmoClient_Tests.testTokenizeVenmoAccount_whenVenmoConfigurationDisabled_callsBackWithError() BTVenmoClient_Tests.testTokenizeVenmoAccount_whenVenmoConfigurationDisabled_callsBackWithError() BTVenmoClient_Tests.testTokenizeVenmoAccount_whenVenmoConfigurationDisabled_callsBackWithError() BTVenmoClient_Tests.testTokenizeVenmoAccount_whenVenmoConfigurationMissing_callsBackWithError() BTVenmoClient_Tests.testTokenizeVenmoAccount_whenVenmoConfigurationMissing_callsBackWithError() BTVenmoClient_Tests.testTokenizeVenmoAccount_whenVenmoConfigurationMissing_callsBackWithError()

Just added it back and tested locally. Seems like removing return was the cause of the failed tests

scannillo · 2024-10-31T19:40:43Z

Demo/UI Tests/Venmo UI Tests/Venmo_UITests.swift

        demoApp = XCUIApplication(bundleIdentifier: "com.braintreepayments.Demo")
        demoApp.launchArguments.append("-EnvironmentSandbox")
        demoApp.launchArguments.append("-ClientToken")
        demoApp.launchArguments.append("-Integration:VenmoViewController")
        demoApp.launch()
    }
-
-    func testTokenizeVenmo_whenSignInSuccessfulWithPaymentContext_returnsNonce() {


We should add a TODO + JIRA ticket for investigating what we want to do about UI tests now that our MockVenmo app will no longer work. (Also likely removing the MockVenmo app entirely, unless we can rig it to mimic Venmo's universal link)

Good point, done!

Ticket https://paypal.atlassian.net/jira/software/c/projects/DTMOBILES/boards/27751?selectedIssue=DTMOBILES-1237

…v7-venmo-universal-link # Conflicts: # CHANGELOG.md

…e/braintree_ios into v7-venmo-universal-link

Removed Venmo fallbacktoWeb

b92fa87

stechiu requested a review from a team as a code owner October 15, 2024 00:28

jaxdesmarais reviewed Oct 15, 2024

View reviewed changes

Sources/BraintreeVenmo/BTVenmoClient.swift Outdated Show resolved Hide resolved

stechiu changed the base branch from main to v7 October 16, 2024 17:10

stechiu added 2 commits October 16, 2024 10:22

Addressed PR comment

3384428

Updated CHANGELOG

1a24560

jaxdesmarais reviewed Oct 17, 2024

View reviewed changes

stechiu added the do not review label Oct 17, 2024

stechiu added 2 commits October 17, 2024 10:08

Merge branch 'v7' of https://github.com/braintree/braintree_ios into …

438dfc7

…v7-venmo-universal-link

Merge branch 'main' of https://github.com/braintree/braintree_ios int…

45f21bc

…o v7-venmo-universal-link # Conflicts: # CHANGELOG.md

stechiu added 2 commits October 17, 2024 13:34

Revert "Merge branch 'v7' of https://github.com/braintree/braintree_ios…

47a89a5

… into v7-venmo-universal-link" This reverts commit 438dfc7, reversing changes made to 1a24560.

Merge branch 'v7-venmo-universal-link' of https://github.com/braintre…

bf49d4f

…e/braintree_ios into v7-venmo-universal-link

stechiu changed the base branch from v7 to main October 17, 2024 20:36

stechiu changed the base branch from main to v7 October 17, 2024 20:43

stechiu removed the do not review label Oct 17, 2024

warmkesselj reviewed Oct 21, 2024

View reviewed changes

Sources/BraintreeVenmo/BTVenmoClient.swift Outdated Show resolved Hide resolved

warmkesselj reviewed Oct 21, 2024

View reviewed changes

Sources/BraintreeVenmo/BTVenmoClient.swift Outdated Show resolved Hide resolved

jaxdesmarais reviewed Oct 22, 2024

View reviewed changes

stechiu added 3 commits October 22, 2024 17:23

Removed LinkType and urlSchemeURL()

3e5842f

Fixed failing unit tests

73575a0

Updated CHANGELOG

0d5916b

jaxdesmarais reviewed Oct 23, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Sources/BraintreePayPal/BTPayPalClient.swift Outdated Show resolved Hide resolved

Sources/BraintreePayPal/BTPayPalReturnURL.swift Outdated Show resolved Hide resolved

Sources/BraintreeVenmo/BTVenmoClient.swift Outdated Show resolved Hide resolved

agedd reviewed Oct 23, 2024

View reviewed changes

Sources/BraintreeVenmo/BTVenmoClient.swift Outdated Show resolved Hide resolved

stechiu added 4 commits October 24, 2024 11:49

Fixed linkType error

cd51766

Added missing linkType parameter

50aaa40

Fixed failing tests

e2c7a67

scannillo reviewed Oct 28, 2024

View reviewed changes

Braintree.podspec Outdated Show resolved Hide resolved

scannillo reviewed Oct 28, 2024

View reviewed changes

Braintree.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved

scannillo reviewed Oct 28, 2024

View reviewed changes

Sources/BraintreeCore/BTHTTP.swift Outdated Show resolved Hide resolved

scannillo reviewed Oct 28, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

stechiu added 6 commits October 28, 2024 12:13

Removed Venmo UI tests. Updated docstrings

d4af84a

Merge branch 'v7' of https://github.com/braintree/braintree_ios into …

c710d4d

…v7-venmo-universal-link

Updated CHANGELOG

c3225a1

Revert "Merge branch 'v7' of https://github.com/braintree/braintree_ios…

2d0d7e0

… into v7-venmo-universal-link" This reverts commit 438dfc7, reversing changes made to 1a24560.

Revert "Revert "Merge branch 'v7' of https://github.com/braintree/bra…

b265b69

…intree_ios into v7-venmo-universal-link"" This reverts commit 2d0d7e0.

Merge branch 'v7' of https://github.com/braintree/braintree_ios into …

0d6f01e

…v7-venmo-universal-link

stechiu added 2 commits October 28, 2024 14:44

Reset v7 files

cb531ad

Removed duplicate LinkType file

5b536c3

stechiu added the v7 label Oct 29, 2024

warmkesselj approved these changes Oct 29, 2024

View reviewed changes

agedd approved these changes Oct 29, 2024

View reviewed changes

Removed unused return

ab02597

jaxdesmarais reviewed Oct 30, 2024

View reviewed changes

scannillo reviewed Oct 31, 2024

View reviewed changes

stechiu and others added 4 commits November 12, 2024 11:22

Merge branch 'v7' of https://github.com/braintree/braintree_ios into …

dae4473

…v7-venmo-universal-link # Conflicts: # CHANGELOG.md

Reverted cocoapods version

c7b615b

Updated migration guide. Added TODO

7a19f68

Merge branch 'v7-venmo-universal-link' of https://github.com/braintre…

5fb49c3

…e/braintree_ios into v7-venmo-universal-link

stechiu merged commit 3867268 into v7 Nov 12, 2024
7 of 8 checks passed

stechiu deleted the v7-venmo-universal-link branch November 12, 2024 23:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed Venmo `fallbacktoWeb` #1434

Removed Venmo `fallbacktoWeb` #1434

stechiu commented Oct 15, 2024 •

edited

Loading

jaxdesmarais left a comment

scannillo commented Oct 16, 2024

stechiu commented Oct 16, 2024

stechiu commented Oct 16, 2024

jaxdesmarais left a comment

stechiu commented Oct 17, 2024

jaxdesmarais commented Oct 17, 2024

warmkesselj Oct 21, 2024

stechiu Oct 21, 2024

warmkesselj Oct 28, 2024

jaxdesmarais left a comment

stechiu commented Oct 23, 2024

jaxdesmarais left a comment

stechiu commented Oct 25, 2024

stechiu commented Oct 28, 2024

warmkesselj left a comment

agedd left a comment

jaxdesmarais Oct 30, 2024

stechiu Nov 12, 2024

scannillo Oct 31, 2024

stechiu Nov 12, 2024

stechiu Nov 12, 2024

Removed Venmo fallbacktoWeb #1434

Removed Venmo fallbacktoWeb #1434

Conversation

stechiu commented Oct 15, 2024 • edited Loading

Summary of changes

Checklist

Authors

jaxdesmarais left a comment

Choose a reason for hiding this comment

scannillo commented Oct 16, 2024

stechiu commented Oct 16, 2024

stechiu commented Oct 16, 2024

jaxdesmarais left a comment

Choose a reason for hiding this comment

stechiu commented Oct 17, 2024

jaxdesmarais commented Oct 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaxdesmarais left a comment

Choose a reason for hiding this comment

stechiu commented Oct 23, 2024

jaxdesmarais left a comment

Choose a reason for hiding this comment

stechiu commented Oct 25, 2024

stechiu commented Oct 28, 2024

warmkesselj left a comment

Choose a reason for hiding this comment

agedd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Removed Venmo `fallbacktoWeb` #1434

Removed Venmo `fallbacktoWeb` #1434

stechiu commented Oct 15, 2024 •

edited

Loading