Fix incorrect typings #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [README](https://github.com/braintree/credit-card-type#adding-card-types) shows an `addCard` example that uses a pattern not currently valid with the `CreditCardType.patterns` type. `[number[]]` should be `number[][]` This accurately represents credit-card-type's pattern functionality and allows the README example to work: ```typescript creditCardType.addCard({ niceType: "Visa with Custom Nice Type", type: creditCardType.types.VISA, patterns: [41111, [44, 47]], gaps: [4, 8, 12], lengths: [13, 16, 19], // add support for old, deprecated 13 digit visas code: { name: "CVV", size: 3, }, }); ```
|
👋 @uPaymeiFixit thanks for the PR! We'll take a look and provide feedback or merge, unfortunately I can't provide an ETA. For internal reference, ticket 1890 |
|
In case it helps, this is the code I'm currently using as a workaround. When this type definition is fixed the CardValidator.creditCardType.addCard({
niceType: 'Deprecated 13 Digit Visa',
type: 'visa-deprecated',
// eslint-disable-next-line @typescript-eslint/no-explicit-any
patterns: [41111, [44, 47]] as any, // Required until this gets merged: https://github.com/braintree/credit-card-type/pull/147
gaps: [4, 8, 12],
lengths: [13, 16, 19], // add support for old, deprecated 13 digit visas
code: {
name: 'CVV',
size: 3,
},
}); |
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README shows an
addCardexample that uses a pattern not currently valid with theCreditCardType.patternstype.[number[]]should benumber[][]This accurately represents credit-card-type's pattern functionality and allows the README example to work: